kellen/gasket-driver
1
0
Fork 0
forked from MIrrors/gasket-driver
Code Pull Requests Actions Packages Activity

staging: gasket: apex: simplify comments for static functions

Browse Source 
Static functions don't need kernel doc formatting, can be simplified.
Reformat comments that can be single-line.  Remove extraneous text.

Change-Id: Ia29594eeb2dd6cea38665d26e130237f5f90c94a
Signed-off-by: Todd Poynor <toddpoynor@google.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Todd Poynor
2018-07-29 12:36:38 -07:00
committed by Alex Van Damme
parent e7585bf384
commit 5193ebb0e4
1 changed files with 11 additions and 59 deletions
Download Patch File Download Diff File Expand all files Collapse all files

70
apex_driver.c
View File

@@ -380,34 +380,20 @@ static int apex_sysfs_setup_cb(struct gasket_dev *gasket_dev)
gasket_dev->dev_info.device, apex_sysfs_attrs);
}
/* On device open, we want to perform a core reinit reset. */
/* On device open, perform a core reinit reset. */
static int apex_device_open_cb(struct gasket_dev *gasket_dev)
{
return gasket_reset_nolock(gasket_dev, APEX_CHIP_REINIT_RESET);
}
/**
* apex_get_status - Set device status.
* @dev: Apex device struct.
*
* Description: Check the device status registers and set the driver status
* to ALIVE or DEAD.
*
* Returns 0 if status is ALIVE, a negative error number otherwise.
*/
/* Check the device status registers and return device status ALIVE or DEAD. */
static int apex_get_status(struct gasket_dev *gasket_dev)
{
/* TODO: Check device status. */
return GASKET_STATUS_ALIVE;
}
/**
* apex_device_cleanup - Clean up Apex HW after close.
* @gasket_dev: Gasket device pointer.
*
* Description: Resets the Apex hardware. Called on final close via
* device_close_cb.
*/
/* Reset the Apex hardware. Called on final close via device_close_cb. */
static int apex_device_cleanup(struct gasket_dev *gasket_dev)
{
u64 scalar_error;
@@ -431,14 +417,7 @@ static int apex_device_cleanup(struct gasket_dev *gasket_dev)
return ret;
}
/**
* apex_reset - Quits reset.
* @gasket_dev: Gasket device pointer.
*
* Description: Resets the hardware, then quits reset.
* Called on device open.
*
*/
/* Reset the hardware, then quit reset. Called on device open. */
static int apex_reset(struct gasket_dev *gasket_dev, uint type)
{
int ret;
@@ -461,9 +440,7 @@ static int apex_reset(struct gasket_dev *gasket_dev, uint type)
return ret;
}
/*
* Enters GCB reset state.
*/
/* Enter GCB reset state. */
static int apex_enter_reset(struct gasket_dev *gasket_dev, uint type)
{
if (bypass_top_level)
@@ -518,9 +495,7 @@ static int apex_enter_reset(struct gasket_dev *gasket_dev, uint type)
return 0;
}
/*
* Quits GCB reset state.
*/
/* Quit GCB reset state. */
static int apex_quit_reset(struct gasket_dev *gasket_dev, uint type)
{
u32 val0, val1;
@@ -603,9 +578,7 @@ static int apex_quit_reset(struct gasket_dev *gasket_dev, uint type)
return 0;
}
/*
* Determines if GCB is in reset state.
*/
/* Determine if GCB is in reset state. */
static bool is_gcb_in_reset(struct gasket_dev *gasket_dev)
{
u32 val = gasket_dev_read_32(
@@ -617,9 +590,6 @@ static bool is_gcb_in_reset(struct gasket_dev *gasket_dev)
/*
* Check permissions for Apex ioctls.
* @file: File pointer from ioctl.
* @cmd: ioctl command.
*
* Returns true if the current user may execute this ioctl, and false otherwise.
*/
static bool apex_ioctl_check_permissions(struct file *filp, uint cmd)
@@ -627,9 +597,7 @@ static bool apex_ioctl_check_permissions(struct file *filp, uint cmd)
return !!(filp->f_mode & FMODE_WRITE);
}
/*
* Apex-specific ioctl handler.
*/
/* Apex-specific ioctl handler. */
static long apex_ioctl(struct file *filp, uint cmd, void __user *argp)
{
struct gasket_dev *gasket_dev = filp->private_data;
@@ -647,11 +615,7 @@ static long apex_ioctl(struct file *filp, uint cmd, void __user *argp)
}
}
/*
* Gates or un-gates Apex clock.
* @gasket_dev: Gasket device pointer.
* @argp: User ioctl arg, pointer to a apex_gate_clock_ioctl struct.
*/
/* Gates or un-gates Apex clock. */
static long apex_clock_gating(struct gasket_dev *gasket_dev,
struct apex_gate_clock_ioctl __user *argp)
{
@@ -685,11 +649,7 @@ static long apex_clock_gating(struct gasket_dev *gasket_dev,
return 0;
}
/*
* apex_set_performance_expectation: Adjust clock rates for Apex.
* @gasket_dev: device pointer.
* @arg: User ioctl arg, in this case to an apex_performance_expectation_ioctl struct.
*/
/* apex_set_performance_expectation: Adjust clock rates for Apex. */
static long apex_set_performance_expectation(struct gasket_dev *gasket_dev, ulong arg)
{
struct apex_performance_expectation_ioctl ibuf;
@@ -751,15 +711,7 @@ static long apex_set_performance_expectation(struct gasket_dev *gasket_dev, ulon
return 0;
}
/*
* Display driver sysfs entries.
* @device: Kernel device structure.
* @attr: Attribute to display.
* @buf: Buffer to which to write output.
*
* Description: Looks up the driver data and file-specific attribute data (the
* type of the attribute), then fills "buf" accordingly.
*/
/* Display driver sysfs entries. */
static ssize_t sysfs_show(
struct device *device, struct device_attribute *attr, char *buf)
{