From f6ac13d5f32edad4ac77e1e40c177dc2bfe9640a Mon Sep 17 00:00:00 2001 From: Todd Poynor Date: Sat, 21 Jul 2018 06:35:06 -0700 Subject: [PATCH] staging: gasket: page table: remove unnecessary logs Some error logs in page table handling code could only be hit in cases of programming errors not expected in the current code base, and aren't likely to be useful on their own. Remove these. Signed-off-by: Todd Poynor Signed-off-by: Greg Kroah-Hartman --- gasket_page_table.c | 23 +++++------------------ 1 file changed, 5 insertions(+), 18 deletions(-) diff --git a/gasket_page_table.c b/gasket_page_table.c index f0c4884..4f2ff77 100644 --- a/gasket_page_table.c +++ b/gasket_page_table.c @@ -605,10 +605,8 @@ EXPORT_SYMBOL(gasket_page_table_is_dev_addr_bad); /* See gasket_page_table.h for description. */ uint gasket_page_table_max_size(struct gasket_page_table *page_table) { - if (!page_table) { - gasket_nodev_error("Passed a null page table."); + if (!page_table) return 0; - } return page_table->config.total_entries; } EXPORT_SYMBOL(gasket_page_table_max_size); @@ -616,11 +614,8 @@ EXPORT_SYMBOL(gasket_page_table_max_size); /* See gasket_page_table.h for description. */ uint gasket_page_table_num_entries(struct gasket_page_table *pg_tbl) { - if (!pg_tbl) { - gasket_nodev_error("Passed a null page table."); + if (!pg_tbl) return 0; - } - return pg_tbl->num_simple_entries + pg_tbl->num_extended_entries; } EXPORT_SYMBOL(gasket_page_table_num_entries); @@ -628,11 +623,8 @@ EXPORT_SYMBOL(gasket_page_table_num_entries); /* See gasket_page_table.h for description. */ uint gasket_page_table_num_simple_entries(struct gasket_page_table *pg_tbl) { - if (!pg_tbl) { - gasket_nodev_error("Passed a null page table."); + if (!pg_tbl) return 0; - } - return pg_tbl->num_simple_entries; } EXPORT_SYMBOL(gasket_page_table_num_simple_entries); @@ -640,11 +632,8 @@ EXPORT_SYMBOL(gasket_page_table_num_simple_entries); /* See gasket_page_table.h for description. */ uint gasket_page_table_num_active_pages(struct gasket_page_table *pg_tbl) { - if (!pg_tbl) { - gasket_nodev_error("Passed a null page table."); + if (!pg_tbl) return 0; - } - return pg_tbl->num_active_pages; } EXPORT_SYMBOL(gasket_page_table_num_active_pages); @@ -652,10 +641,8 @@ EXPORT_SYMBOL(gasket_page_table_num_active_pages); /* See gasket_page_table.h */ int gasket_page_table_system_status(struct gasket_page_table *page_table) { - if (!page_table) { - gasket_nodev_error("Passed a null page table."); + if (!page_table) return GASKET_STATUS_LAMED; - } if (gasket_page_table_num_entries(page_table) == 0) { gasket_nodev_debug("Page table size is 0.");