kellen/gasket-driver
1
0
Fork 0
forked from MIrrors/gasket-driver
Code Pull Requests Actions Packages Activity

Staging: Gasket: shift wrapping bug in gasket_read_modify_write_64()

Browse Source 
This function only has one caller so mask_width is 1 and mask_shift is
32.  Shifting an int by 32 bits is undefined, but I guess on GCC it
wraps to 0x1?  Anyway it's supposed to be 0x100000000.

Fixes: 9a69f5087ccc ("drivers/staging: Gasket driver framework + Apex driver")
Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Signed-off-by: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
This commit is contained in:
Dan Carpenter
2018-07-06 11:39:21 +03:00
committed by Alex Van Damme
parent 85a2ab89f4
commit 14da0230d8
1 changed files with 1 additions and 1 deletions
Download Patch File Download Diff File Expand all files Collapse all files

2
gasket_core.h
View File

@@ -683,7 +683,7 @@ static inline void gasket_read_modify_write_64(
u64 mask, tmp;
tmp = gasket_dev_read_64(dev, bar, location);
mask = ((1 << mask_width) - 1) << mask_shift;
mask = ((1ULL << mask_width) - 1) << mask_shift;
tmp = (tmp & ~mask) | (value << mask_shift);
gasket_dev_write_64(dev, tmp, bar, location);
}